Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force node executions to pull their status #737

Merged
merged 25 commits into from
Apr 17, 2023

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Mar 31, 2023

TL;DR

Running node executions should poll for their status

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Node executions are now polling for their status while in view as long as they are running.

@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and james-union and removed request for a team March 31, 2023 07:10
@ursucarina ursucarina force-pushed the carina/statuspolling branch from bc8573d to c9d8678 Compare April 10, 2023 14:44
@ursucarina ursucarina marked this pull request as ready for review April 12, 2023 06:09
@ursucarina ursucarina force-pushed the carina/statuspolling branch from 1d37237 to 546b3b6 Compare April 14, 2023 20:55
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #737 (4895a0f) into master (33ee52a) will decrease coverage by 0.24%.
The diff coverage is 68.28%.

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   66.63%   66.40%   -0.24%     
==========================================
  Files         466      474       +8     
  Lines       11420    11683     +263     
  Branches     2105     2151      +46     
==========================================
+ Hits         7610     7758     +148     
- Misses       3810     3925     +115     
Impacted Files Coverage Δ
...s/Executions/ExecutionDetails/ExecutionDetails.tsx 0.00% <0.00%> (ø)
...ls/TaskExecutionNodeRenderer/TaskExecutionNode.tsx 0.00% <0.00%> (ø)
...xecutionNodeRenderer/TaskExecutionNodeRenderer.tsx 0.00% <0.00%> (ø)
...rc/components/Executions/ExecutionDetails/utils.ts 86.95% <0.00%> (+6.95%) ⬆️
...ions/TerminateExecution/TerminateExecutionForm.tsx 54.16% <ø> (ø)
...ackages/console/src/components/Executions/types.ts 100.00% <ø> (ø)
...c/components/Launch/LaunchForm/CollectionInput.tsx 26.66% <ø> (ø)
...sole/src/components/Launch/LaunchForm/MapInput.tsx 13.08% <ø> (+0.12%) ⬆️
...e/src/components/Launch/LaunchForm/StructInput.tsx 54.34% <ø> (ø)
packages/console/src/components/Theme/constants.ts 77.04% <ø> (ø)
... and 64 more

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ursucarina ursucarina force-pushed the carina/statuspolling branch from 546b3b6 to 521f109 Compare April 14, 2023 22:22
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina force-pushed the carina/statuspolling branch from 521f109 to 4895a0f Compare April 17, 2023 21:39
@jsonporter jsonporter merged commit 27238ce into master Apr 17, 2023
@jsonporter jsonporter deleted the carina/statuspolling branch April 17, 2023 22:33
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants