-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: force node executions to pull their status #737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ursucarina
requested review from
a team,
jsonporter,
4nalog and
james-union
and removed request for
a team
March 31, 2023 07:10
ursucarina
force-pushed
the
carina/statuspolling
branch
from
April 10, 2023 14:44
bc8573d
to
c9d8678
Compare
ursucarina
force-pushed
the
carina/statuspolling
branch
from
April 14, 2023 20:55
1d37237
to
546b3b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 66.63% 66.40% -0.24%
==========================================
Files 466 474 +8
Lines 11420 11683 +263
Branches 2105 2151 +46
==========================================
+ Hits 7610 7758 +148
- Misses 3810 3925 +115
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ursucarina
force-pushed
the
carina/statuspolling
branch
from
April 14, 2023 22:22
546b3b6
to
521f109
Compare
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
ursucarina
force-pushed
the
carina/statuspolling
branch
from
April 17, 2023 21:39
521f109
to
4895a0f
Compare
jsonporter
approved these changes
Apr 17, 2023
🎉 This PR is included in version 1.6.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Running node executions should poll for their status
Type
Are all requirements met?
Complete description
Node executions are now polling for their status while in view as long as they are running.