Add support fetching description entity #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
+ Coverage 66.06% 66.09% +0.02%
==========================================
Files 485 488 +3
Lines 11764 11806 +42
Branches 2164 2171 +7
==========================================
+ Hits 7772 7803 +31
- Misses 3992 4003 +11
|
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
changed the title
jsonporter
reviewed
Mar 30, 2023
| className={classnames({ | ||
| [commonStyles.hintText]: !hasDescription, | ||
| })} | ||
| > | ||
| {hasDescription | ||
| ? metadata.description | ||
| ? descriptionEntity?.longDescription?.value | ||
| : t( | ||
| patternKey('noDescription', entityStrings[id.resourceType]), |
There was a problem hiding this comment.
For some reason this bit doesn't seem to be working; ran a debugger and verified hasDescription is false but it doesn't seem to render the string?
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
|
It's a neat feature. Is there any blocker for merging it? @pingsutw @jsonporter |
jsonporter
approved these changes
May 5, 2023
ursucarina
pushed a commit
that referenced
this pull request
May 10, 2023
* Add Description entity Signed-off-by: Kevin Su <[email protected]> * Add Description entity Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * address comment Signed-off-by: Kevin Su <[email protected]> * test ci Signed-off-by: Kevin Su <[email protected]> * test ci Signed-off-by: Kevin Su <[email protected]> * test ci Signed-off-by: Kevin Su <[email protected]> * test ci Signed-off-by: Kevin Su <[email protected]> * test ci Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Jason Porter <[email protected]> Signed-off-by: Carina Ursu <[email protected]>
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Type
Are all requirements met?
Complete description
Tracking Issue
NA
Follow-up issue
NA