chore: task observability #720

ursucarina · 2023-03-11T00:48:09Z

TL;DR

Initial setup for task observability

Type

Bug Fix
Feature
Plugin

Are all requirements met?

Complete description

To setup:

run git fetch -p && git checkout carina/obs
run make pack
cd packages/console
yalc publish
run yarn build:watch

Go to cloud/clients repo

run git fetch -p && git checkout carina/obs
run make prep_console
cd packages/zapp/console
run yalc add @flyteorg/console
run yarn start

codecov · 2023-03-11T00:59:09Z

Codecov Report

Merging #720 (4307197) into master (c968593) will decrease coverage by 0.13%.
The diff coverage is 28.75%.

❗ Current head 4307197 differs from pull request most recent head 4f1426a. Consider uploading reports for the commit 4f1426a to get more accurate results

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   66.88%   66.76%   -0.13%     
==========================================
  Files         455      462       +7     
  Lines       11289    11355      +66     
  Branches     2080     2086       +6     
==========================================
+ Hits         7551     7581      +30     
- Misses       3738     3774      +36

Impacted Files	Coverage Δ
packages/console/src/basics/index.ts	`0.00% <0.00%> (ø)`
packages/console/src/common/index.ts	`0.00% <0.00%> (ø)`
packages/console/src/components/App/App.tsx	`0.00% <0.00%> (ø)`
...xecutions/TaskExecutionsList/TaskExecutionLogs.tsx	`95.23% <0.00%> (ø)`
...onsole/src/components/Navigation/NavBarContent.tsx	`0.00% <0.00%> (ø)`
packages/console/src/components/common/index.ts	`0.00% <0.00%> (ø)`
packages/console/src/components/index.ts	`0.00% <0.00%> (ø)`
packages/console/src/models/index.ts	`0.00% <0.00%> (ø)`
packages/console/src/routes/ApplicationRouter.tsx	`0.00% <0.00%> (ø)`
packages/console/src/routes/NavBarRouter.tsx	`0.00% <0.00%> (ø)`
... and 8 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

packages/console/src/components/Executions/TaskExecutionsList/TaskExecutionObservability.tsx

Signed-off-by: Carina Ursu <[email protected]>

* chore: tlro basic setup Signed-off-by: Carina Ursu <[email protected]> * progress checkin * Stable state refactored to use generic naming * updated types * working before updating routes * chore: progress Signed-off-by: Carina Ursu <[email protected]> * chore: remove debugger Signed-off-by: Carina Ursu <[email protected]> * chore: allow custom class in execution actions Signed-off-by: Carina Ursu <[email protected]> * chore: lint fix Signed-off-by: Carina Ursu <[email protected]> * chore: bump console Signed-off-by: Carina Ursu <[email protected]> * chore: up package version Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Jason Porter <[email protected]> Signed-off-by: 4nalog <[email protected]>

* fix: type error on invalid nested json input Signed-off-by: 4nalog <[email protected]> * LaunchForm RJSF Form issue (#692) * fix: launchform Signed-off-by: James <[email protected]> * fix: stuck issue Signed-off-by: James <[email protected]> * fix: on form change Signed-off-by: James <[email protected]> * fix: merge master into branch Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: bump minor version Signed-off-by: 4nalog <[email protected]> * fix: package version to 1.4.2 (#700) Signed-off-by: Jason Porter <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: project settings dashbboard tests (#701) * fix: project settings dashbboard tests Signed-off-by: 4nalog <[email protected]> * chore: remove .only Signed-off-by: 4nalog <[email protected]> * refactor: remove empty waitFor Signed-off-by: 4nalog <[email protected]> --------- Signed-off-by: 4nalog <[email protected]> * fix: upgrading node version to 18 (#703) Upgrading node version to 18 Signed-off-by: Jason Porter <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: revert node version (#704) * fix: revert node version Signed-off-by: Carina Ursu <[email protected]> * Revert "fix: upgrading node version to 18 (#703)" This reverts commit e5f9a8b. Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: deployment optimization (#706) * fix: deployment optimization Signed-off-by: Carina Ursu <[email protected]> * clean up node modules and one file that we think is not needed Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> * fix: upgrade release node version (#707) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: update chalk, add semantic-release test cmd (#708) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: implement logic to handle multiple keys for nested data classes Signed-off-by: 4nalog <[email protected]> * chore: fix update_npmversion (#709) * chore: fix update_npmversion Signed-off-by: Carina Ursu <[email protected]> * chore: edits Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * Mapped Tasks not showing cache status correctly. (#712) * fix: cache status logs indexing mismatch and react rendering cycle issue Signed-off-by: James <[email protected]> * fix: mapped task cache status Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: cleanup, passthrough runtime variables (#710) fix: passthrough runtime variables Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: update_npmversion (#713) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: fix sed makefile error (#714) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * FE: Update flyteconsole to Node 18 (#717) fix: nodejs 18 upgrade Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: allow complex workflow names (#715) * chore: allow complex workflow names Signed-off-by: Carina Ursu <[email protected]> * chore: fix buold:watch Signed-off-by: Carina Ursu <[email protected]> * chore: yarn.lock Signed-off-by: Carina Ursu <[email protected]> * chore: upgrade package Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> * chore: show correct app version in info (#716) * chore: show correct app version in info Signed-off-by: Carina Ursu <[email protected]> * chore: update ver Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: left nav doesn't accurately update on workflow version page (#718) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * feat: differentiate between cache disabled and cache put failure (#719) fix: add icon for put failure Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: fix formatting Signed-off-by: 4nalog <[email protected]> * fix: add material-ui class name seed (#721) * chore: add material-ui class name seed Signed-off-by: Carina Ursu <[email protected]> * fix: overflow of modal Signed-off-by: James <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * The rendering of node status in a dynamic workflow is not functioning correctly (#723) fix: dynamic nodes status Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: backfill index on execution task logs (#725) * chore: backfill index on execution task logs Signed-off-by: Carina Ursu <[email protected]> * chore: add comments Signed-off-by: Carina Ursu <[email protected]> * chore: bump version Signed-off-by: Carina Ursu <[email protected]> * chore: remove backfill Signed-off-by: Carina Ursu <[email protected]> * chore: lint Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: release fail (#726) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * Install deps directly in checks.yml (#728) Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: show correct i/o in details panel (#727) * chore: show correct i/o in details panel Signed-off-by: Carina Ursu <[email protected]> * chore: bump version Signed-off-by: Carina Ursu <[email protected]> * chore: feedback Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: task observability (#720) * chore: tlro basic setup Signed-off-by: Carina Ursu <[email protected]> * progress checkin * Stable state refactored to use generic naming * updated types * working before updating routes * chore: progress Signed-off-by: Carina Ursu <[email protected]> * chore: remove debugger Signed-off-by: Carina Ursu <[email protected]> * chore: allow custom class in execution actions Signed-off-by: Carina Ursu <[email protected]> * chore: lint fix Signed-off-by: Carina Ursu <[email protected]> * chore: bump console Signed-off-by: Carina Ursu <[email protected]> * chore: up package version Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Jason Porter <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: fix contextual menu action buttons color (#730) * chore: fix contextual menu action buttons color Signed-off-by: Carina Ursu <[email protected]> * chore: up console version Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: add build:watch to all packages (#731) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * Add REJECT support for ApprovedCondition for GateNodes (#733) * fix: approveCondition reject Signed-off-by: James <[email protected]> * fix: approve button Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * gate node in dynamic task (#729) * fix: gate node in dynamic Signed-off-by: James <[email protected]> * fix: upgraded version Signed-off-by: James <[email protected]> * fix: compiledNode in PausedTasksComponent and ExecutionDetailsActions Signed-off-by: James <[email protected]> * fix: upgrade version Signed-off-by: James <[email protected]> * chore: lockfile Signed-off-by: Carina Ursu <[email protected]> * fix: remove caching for workflow closure Signed-off-by: James <[email protected]> * fix: break link between cache and context state Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: comments Signed-off-by: 4nalog <[email protected]> --------- Signed-off-by: 4nalog <[email protected]> Signed-off-by: James <[email protected]> Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: james-union <[email protected]> Co-authored-by: Jason Porter <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: James <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> Co-authored-by: Jason Porter <[email protected]>

flyte-bot · 2023-03-30T20:36:07Z

🎉 This PR is included in version 1.5.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ursucarina requested review from a team, jsonporter, olga-union and james-union and removed request for a team March 11, 2023 16:48

jsonporter reviewed Mar 13, 2023

View reviewed changes

packages/console/src/components/Executions/TaskExecutionsList/TaskExecutionObservability.tsx Outdated Show resolved Hide resolved

ursucarina marked this pull request as ready for review March 15, 2023 16:52

ursucarina force-pushed the carina/obs branch from 6ebf57a to bf468fa Compare March 15, 2023 22:19

ursucarina and others added 7 commits March 20, 2023 15:34

chore: tlro basic setup

8ff9226

Signed-off-by: Carina Ursu <[email protected]>

progress checkin

ac114f1

Stable state refactored to use generic naming

b1d97e0

updated types

c3f85b4

working before updating routes

6162e7d

chore: progress

c4eac52

Signed-off-by: Carina Ursu <[email protected]>

chore: remove debugger

672017b

Signed-off-by: Carina Ursu <[email protected]>

ursucarina force-pushed the carina/obs branch from 7bdbb77 to 672017b Compare March 20, 2023 22:35

ursucarina added 5 commits March 20, 2023 16:05

chore: allow custom class in execution actions

86c1713

Signed-off-by: Carina Ursu <[email protected]>

chore: lint fix

a509b1a

Signed-off-by: Carina Ursu <[email protected]>

chore: bump console

d33aa6c

Signed-off-by: Carina Ursu <[email protected]>

chore: up package version

9c17c5d

Signed-off-by: Carina Ursu <[email protected]>

Merge branch 'master' into carina/obs

4307197

ursucarina enabled auto-merge (squash) March 22, 2023 17:54

Removed context that wasn't needed

4f1426a

jsonporter approved these changes Mar 22, 2023

View reviewed changes

ursucarina merged commit 35c3b8c into master Mar 22, 2023

ursucarina deleted the carina/obs branch March 22, 2023 19:15

flyte-bot added the released label Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: task observability #720

chore: task observability #720

ursucarina commented Mar 11, 2023 •

edited

Loading

codecov bot commented Mar 11, 2023 •

edited

Loading

flyte-bot commented Mar 30, 2023

chore: task observability #720

chore: task observability #720

Conversation

ursucarina commented Mar 11, 2023 • edited Loading

TL;DR

Type

Are all requirements met?

Complete description

codecov bot commented Mar 11, 2023 • edited Loading

Codecov Report

flyte-bot commented Mar 30, 2023

ursucarina commented Mar 11, 2023 •

edited

Loading

codecov bot commented Mar 11, 2023 •

edited

Loading