Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add domain settings for project dashboard #689

Merged
merged 9 commits into from
Feb 23, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: use exact imports from lodash
Signed-off-by: 4nalog <4nalog@protonmail.com>
4nalog committed Feb 22, 2023
commit b3c8a5f5e659b8d1744cbd7aa06497c9c8ce51dc
4 changes: 2 additions & 2 deletions packages/console/src/components/Project/ProjectDashboard.tsx
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ import { useOnlyMyExecutionsFilterState } from 'components/Executions/filters/us
import { WaitForData } from 'components/common/WaitForData';
import { history } from 'routes/history';
import { Routes } from 'routes/routes';
import _, { compact } from 'lodash';
import { compact, merge } from 'lodash';
import {
getProjectAttributes,
getProjectDomainAttributes,
@@ -211,7 +211,7 @@ export const ProjectDashboard: React.FC<ProjectDashboardProps> = ({
);

const configData =
_.merge(
merge(
projectAttributesQuery.data?.attributes?.matchingAttributes
?.workflowExecutionConfig,
projectDomainAttributesQuery.data?.attributes?.matchingAttributes
4 changes: 2 additions & 2 deletions packages/console/src/models/Project/utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import { compact } from 'lodash';
import { Identifier } from 'models/Common/types';
import { Project } from './types';

@@ -16,5 +16,5 @@ export function makeProjectDomainAttributesPath(
prefix: string,
{ project, domain }: Partial<Identifier>,
) {
return _.compact([prefix, project, domain]).join('/');
return compact([prefix, project, domain]).join('/');
}