Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ApprovedCondition for GateNodes #688

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

james-union
Copy link
Contributor

@james-union james-union commented Feb 10, 2023

https://github.com/unionai/cloud/issues/1518

The example workflow to reproduce the issue
https://localhost.development.uniondemo.run:3000/projects/flytesnacks/domains/development/workflows/core.control_flow.human_in_the_loop.mainwf?duration=all

To reproduce, you can launch a new workflow and there will be a paused node. You can click the play button and then see the modal for approvedCondition

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@james-union james-union self-assigned this Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #688 (a7778ff) into master (27d4344) will increase coverage by 0.44%.
The diff coverage is 80.00%.

❗ Current head a7778ff differs from pull request most recent head 22c8b9c. Consider uploading reports for the commit 22c8b9c to get more accurate results

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
+ Coverage   67.18%   67.62%   +0.44%     
==========================================
  Files         453      452       -1     
  Lines       11210    11207       -3     
  Branches     2065     2065              
==========================================
+ Hits         7531     7579      +48     
+ Misses       3679     3628      -51     
Impacted Files Coverage Δ
...tions/ExecutionDetails/ExecutionDetailsActions.tsx 83.87% <ø> (ø)
...ponents/Executions/Tables/NodeExecutionActions.tsx 91.04% <ø> (ø)
...le/src/components/Launch/LaunchForm/ResumeForm.tsx 71.42% <ø> (ø)
.../src/components/Launch/LaunchForm/launchMachine.ts 88.88% <ø> (ø)
...ents/flytegraph/ReactFlow/customNodeComponents.tsx 19.18% <ø> (+0.47%) ⬆️
...components/Launch/LaunchForm/LaunchFormActions.tsx 89.74% <62.50%> (-7.23%) ⬇️
...components/Launch/LaunchForm/useResumeFormState.ts 90.47% <85.71%> (-1.42%) ⬇️
.../components/Launch/LaunchForm/LaunchFormDialog.tsx 76.19% <100.00%> (ø)
.../components/Launch/LaunchForm/ResumeSignalForm.tsx 100.00% <100.00%> (ø)
...ents/flytegraph/ReactFlow/PausedTasksComponent.tsx 73.07% <100.00%> (+1.07%) ⬆️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@james-union james-union force-pushed the james/approveCondition branch from a7778ff to 22c8b9c Compare February 20, 2023 17:45
@jsonporter jsonporter merged commit 860e356 into master Feb 21, 2023
@jsonporter jsonporter deleted the james/approveCondition branch February 21, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants