Resume Signal Form

[james-union]

https://github.com/flyteorg/flyteconsole/issues/587

TL;DR

• SetSignal is still waiting to be deployed on the backend side

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/587

[olga-union]

Left some clean-up feedback, but haven't smoke tested yet.
One more item to think of - we use 3 different names for launch form trigger resumeOnClick, resumeAction, handleActionClick, let's pick one (maybe a different one) and stick to it, to improve search-ability of these blocks in future

[olga-union]

Don't forget to include flyteidl update in this PR - ignore for now, looks like v1.1.22 doesn't have gate nodes

[olga-union]

Almost there - few nits in the comments, let's move string from constants.ts file to a newly created localization strings.ts (more info in unresolved comments) in the LaunchForm folder, and rename resumeAction/resumeOnClick/handleActionClick with the same name!

[olga-union]

Nice job! Few tiny things left, and don't forget to checkout package.jsons you accidentally committed 😃

[codecov]

Codecov Report

Merging #622 (578943d) into devmain (bc2dd8e) will increase coverage by 0.21%.
The diff coverage is 74.02%.

@@             Coverage Diff             @@
##           devmain     #622      +/-   ##
===========================================
+ Coverage    67.35%   67.57%   +0.21%     
===========================================
  Files          398      447      +49     
  Lines         9296    10648    +1352     
  Branches      1590     1831     +241     
===========================================
+ Hits          6261     7195     +934     
- Misses        3035     3453     +418     

Impacted Files	Coverage Δ
...zapp/console/src/basics/FeatureFlags/AdminFlag.tsx	94.11% <ø> (ø)
...p/console/src/basics/FeatureFlags/FeatureFlags.tsx	93.54% <ø> (ø)
...ges/zapp/console/src/basics/FeatureFlags/index.tsx	100.00% <ø> (ø)
packages/zapp/console/src/common/env.ts	100.00% <ø> (ø)
packages/zapp/console/src/common/layout.ts	100.00% <ø> (ø)
packages/zapp/console/src/common/linkify.ts	100.00% <ø> (ø)
packages/zapp/console/src/common/log.ts	100.00% <ø> (ø)
packages/zapp/console/src/common/promiseUtils.ts	0.00% <ø> (ø)
packages/zapp/console/src/common/timer.ts	0.00% <ø> (ø)
packages/zapp/console/src/common/timezone.ts	100.00% <ø> (ø)
... and 404 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[james-union]

@olga-union I've fixed your comments. Just FYI, the flyteidl version is not yet updated because if it points to 1.1.14, it fails to build as Core.SignalIdentifier is not defined.
For the tests, I've fixed PausedTasksComponent & NodeExecutionActions

Still working on ResumeSignalForm