Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status banner cleanup #57

Merged
merged 7 commits into from
Apr 6, 2020
Merged

Status banner cleanup #57

merged 7 commits into from
Apr 6, 2020

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Apr 6, 2020

flyteorg/flyte#223

This wraps up the work to display a status banner based on the presence of env.STATUS_URL and a valid message payload.

  • Fixed some layout issues with the banner that caused the text to not fill the available space
  • Added tests for existing code
  • Brought in linkify-it, added utility function to split a string of text into chunks based on the presence of valid links.
  • Added a LinkifiedText component which uses the new utility function to split a string and then renders any links found as inline anchor tags which open in a new tab

image

Copy link

@podehnal podehnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@schottra schottra merged commit 4a3b96d into status-endpoints Apr 6, 2020
@schottra schottra deleted the status-banner-cleanup branch April 6, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants