feat: webpack config changes #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ursucarina
requested review from
a team,
anrusina,
jsonporter and
olga-union
and removed request for
a team
anrusina
reviewed
Apr 22, 2022
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 67.08% 67.25% +0.17%
==========================================
Files 407 406 -1
Lines 9147 9123 -24
Branches 1614 1610 -4
==========================================
Hits 6136 6136
+ Misses 3011 2987 -24
Continue to review full report at Codecov.
|
anrusina
reviewed
Apr 22, 2022
anrusina
reviewed
Apr 22, 2022
anrusina
reviewed
Apr 22, 2022
anrusina
reviewed
Apr 22, 2022
anrusina
reviewed
Apr 22, 2022
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
anrusina
reviewed
Apr 22, 2022
| } | ||
| const distPath = path.join(__dirname, 'dist'); | ||
| app.use( | ||
| // This path should be in sync with the `publicPath` from webpack config. |
There was a problem hiding this comment.
nit: this comment is redundant
anrusina
reviewed
Apr 22, 2022
| const BASE_URL = process.env.BASE_URL || ''; | ||
|
|
||
| /** All emitted assets will have relative path to this path | ||
| * every time it is changed - the index.js app.use should also be updated. |
There was a problem hiding this comment.
nit - line 19 is redundant
anrusina
approved these changes
Apr 22, 2022
flyte-bot
added a commit
that referenced
this pull request
Apr 22, 2022
# [0.55.0](http://github.com/lyft/flyteconsole/compare/v0.54.2...v0.55.0) (2022-04-22) ### Features * webpack config changes ([#419](http://github.com/lyft/flyteconsole/issues/419)) ([f93e94f](http://github.com/lyft/flyteconsole/commit/f93e94fd5b04c8da65b0bcd97ce1097451d83b28))
|
🎉 This PR is included in version 0.55.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to webpack configuration
Type
Are all requirements met?
Complete description
Separate dev & prod settings to two files
Always clean builds
Fix for hot reload feature
Use CDN for react and react-dom in prod
Open local site in chrome browser after webpack build is ready (when yarn start is used)