Fix: assets path for index.js query #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Bain (Level 5 US)/Alex Bain <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
requested review from
a team,
ursucarina,
jsonporter and
olga-union
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 67.08% 67.08%
=======================================
Files 407 407
Lines 9147 9147
Branches 1614 1614
=======================================
Hits 6136 6136
Misses 3011 3011 Continue to review full report at Codecov.
|
Signed-off-by: Nastya Rusina <[email protected]>
|
@convexquad If you can check it on your side it would be amazing |
|
I built and tested in my EKS cluster and everything is working for me |
|
🎉 This PR is included in version 0.54.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue raised by one of our users who had different domains for console and admin api.
In his case all Admin API request performed at
ui_domain/consolewhere navigated toui_domain/api/v1/requestinstead ofadmin_api/api/v1/request.However if request performed from any other page , for example
domain/console/projects/flytectldemo/workflowsit will work as expect.This change adds back
/assetsfolder to hold main.js and vendor.js and puts assets at the same/assetsfolderType
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/