chore: remove redundant docker build on merge to master #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 405 405
Lines 9063 9063
Branches 1600 1600
=======================================
Hits 6021 6021
Misses 3042 3042 Continue to review full report at Codecov.
|
|
@katrogan should we revert this ? |
katrogan
pushed a commit
that referenced
this pull request
Apr 15, 2022
This reverts commit 46db242.
katrogan
pushed a commit
that referenced
this pull request
Apr 15, 2022
flyte-bot
added a commit
that referenced
this pull request
Apr 15, 2022
## [0.52.1](http://github.com/lyft/flyteconsole/compare/v0.52.0...v0.52.1) (2022-04-15) ### Reverts * Revert "chore: remove redundant docker build on merge to master (#390)" (#392) ([fb564f3](http://github.com/lyft/flyteconsole/commit/fb564f33c490859ecb7b2cfb4c3a6a6294de3530)), closes [#390](http://github.com/lyft/flyteconsole/issues/390) [#392](http://github.com/lyft/flyteconsole/issues/392)
|
🎉 This PR is included in version 0.52.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan [email protected]
TL;DR
Currently on merge to master we run the
Build & Push Flyteconsole Imagegithub action twice: one instance only builds the docker image and the second instance builds and pushes it.This change makes it so we build the image on open PRs and build and push the image on merges.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
NA
Follow-up issue
NA