Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate relaunch into page #38

Merged
merged 4 commits into from
Feb 10, 2020

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Feb 5, 2020

flyteorg/flyte#84
This change integrates the new Launch form support for initializing from a workflow/launch plan/inputs with the ExecutionDetails view. The 'Relaunch' button on the ExecutionDetails page no longer displays a small confirmation modal, but instead will load the appropriate execution/workflow details and then display the LaunchForm initialized using those values.

  • Added component to fetch the workflow for an execution, get its inputs, and then plug them into a useExecutionLaunchConfiguration hook and render the LaunchWorkflowForm with the results.
  • Removed the RelaunchExecution component folder which implemented the old minimal form
  • Fixed bad calls to list a single launch plan/workflow based on version. Those need to use a filter.
  • Updated unit tests related to the above bug fix
  • Removed some unused imports in the TaskExecutionDetails app bar content. One of them caused errors by attempting to include the old relaunch form (despite it not being used). I took the opportunity to clean up all the unused imports in that file.

RelaunchFromExecution

@schottra schottra requested review from mrmcduff and ttannis February 5, 2020 23:48
@schottra schottra merged commit 619c0d8 into relaunch-with-edits Feb 10, 2020
@schottra schottra deleted the integrate-relaunch-into-page branch February 10, 2020 20:19
@schottra schottra mentioned this pull request Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant