chore: separate nodeDetailsPanel + add story for taskExecutionsList #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
requested review from
a team,
jsonporter and
olga-union
and removed request for
a team
Signed-off-by: Nastya Rusina <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 65.38% 65.48% +0.09%
==========================================
Files 394 395 +1
Lines 8774 8784 +10
Branches 1519 1520 +1
==========================================
+ Hits 5737 5752 +15
+ Misses 3037 3032 -5
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 0.48.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a storybook for TaskExecutionsList, as a start point to adding new treatment for MapTasks.
I also separated NodeDetailsPanel - so we can add more stories in a more simple way in future.
Type
Are all requirements met?
Complete description
I received a JSON dump for mapped task representation, we would need to update some Figma UIs to be on par with it.
While code is still not pushed to Admin - we can update UI and track all navigations using new storybook features.
The easiest way to do so - is using storybook with JSON dumps.
This PR adds storybook representation for TaskExecutionsList which currently shows default version in JSON dump for regular PytonTask. The MapTask plan to be implemented in next step.
Tracking Issue
https://github.com/flyteorg/flyteconsole/issues/310 - prepares code to easier implementation
Signed-off-by: Nastya Rusina [email protected]