chore: eslint cleanup - eqeqeq, unused experession, index key #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
requested review from
a team,
jsonporter and
olga-union
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 65.33% 65.38% +0.04%
==========================================
Files 394 394
Lines 8770 8774 +4
Branches 1518 1519 +1
==========================================
+ Hits 5730 5737 +7
+ Misses 3040 3037 -3
Continue to review full report at Codecov.
|
Signed-off-by: Nastya Rusina <[email protected]>
olga-union
reviewed
Mar 31, 2022
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
force-pushed
the
narusina/eslint_03_30
branch
from
cfab415 to
8adfaeb
Compare
|
🎉 This PR is included in version 0.48.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint related cleanup with no logic changes.
All non-obvious fixes where skipped for now. Covered next rules:
eqeqeq- When == used instead of ===react/no-array-index-key- it's not safe to use index as key in the arrays (it's default behaviour, so don't even have much sense) - replaced where a different unique identified already availableType
Are all requirements met?
Signed-off-by: Nastya Rusina [email protected]