fix: long node-id obscures task type #patch #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
commented
Mar 7, 2022
Comment on lines
+82
to
+87
| const nodeId = displayId ?? execution.id.nodeId; | ||
| return ( | ||
| <Tooltip arrow title={nodeId} placement="top-start"> | ||
| <div className={commonStyles.truncateText}>{nodeId}</div> | ||
| </Tooltip> | ||
| ); |
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 64.40% 64.39% -0.01%
==========================================
Files 392 392
Lines 8844 8842 -2
Branches 1588 1587 -1
==========================================
- Hits 5696 5694 -2
Misses 3148 3148
Continue to review full report at Codecov.
|
flyte-bot
added a commit
that referenced
this pull request
Mar 14, 2022
# [0.44.0](http://github.com/lyft/flyteconsole/compare/v0.43.0...v0.44.0) (2022-03-14) ### Bug Fixes * long node-id obscures task type ([#308](http://github.com/lyft/flyteconsole/issues/308)) ([50b5ef5](http://github.com/lyft/flyteconsole/commit/50b5ef51951301fb828ee0cf6f5bfc6cb1546920)) ### Features * Support for dynamic and nested workflows. ([#326](http://github.com/lyft/flyteconsole/issues/326)) ([5cd1ca5](http://github.com/lyft/flyteconsole/commit/5cd1ca57e9f5d64db96a1ebe9f8a19c1c14743fc))
|
🎉 This PR is included in version 0.44.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap text with ellipsis if it's too long, and add Tooltip, so we can still see whole display-id.
Most changes a whitespace only, I marked the fix with a comment
Prior to the fix:
After the fix:
Type
Are all requirements met?
Complete description
The main point described in issue 292 was fixed in flyteconsole v.0.42.1
The only issue left - was nodeId is not fully readable and obscuring the view, in case if id is too long to fit into a cell. This PR fixes it.
fixes https://github.com/flyteorg/flyteconsole/issues/292