fix: performance issue related to search #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: csirius <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=========================================
Coverage ? 63.15%
=========================================
Files ? 370
Lines ? 8110
Branches ? 1433
=========================================
Hits ? 5122
Misses ? 2988
Partials ? 0 Continue to review full report at Codecov.
|
jsonporter
approved these changes
Dec 7, 2021
flyte-bot
added a commit
that referenced
this pull request
Dec 7, 2021
## [0.33.1](http://github.com/lyft/flyteconsole/compare/v0.33.0...v0.33.1) (2021-12-07) ### Bug Fixes * performance issue related to search ([#250](http://github.com/lyft/flyteconsole/issues/250)) ([210a3ff](http://github.com/lyft/flyteconsole/commit/210a3ff49e220f8ed8268a21dfd030e9dc6d175b))
|
🎉 This PR is included in version 0.33.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: csirius [email protected]
TL;DR
Workflow new search UX performance issue fix.
Type
Are all requirements met?
Complete description
Workflow new search UX performance issue fix.
Added debounce search and stale time for react query.
Changed key prop and use React memo for performance optimization.
Tracking Issue
NA
Follow-up issue
NA