Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back button on execution detail page #190

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

Pianist038801
Copy link
Contributor

Signed-off-by: Pianist038801 [email protected]

Initially, when navigating to the Execution Details page via the project-level Executions list, the back button was leading to the wrong view (Workflow list or Task list).
Now it's fixed to return back to the Executions list.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

fixes flyteorg/flyte#662

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@69aa779). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage          ?   66.68%           
=========================================
  Files             ?      348           
  Lines             ?     7274           
  Branches          ?     1236           
=========================================
  Hits              ?     4851           
  Misses            ?     2423           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69aa779...9af702f. Read the comment docs.

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.23.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anrusina anrusina deleted the fix/back-button-on-execution-detail-page branch January 13, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][UI] Back button on Execution Details page does not always go to the right place.
3 participants