Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render recovered node execution status #177

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Render recovered node execution status #177

merged 2 commits into from
Jul 23, 2021

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Jul 23, 2021

Signed-off-by: Katrina Rogan [email protected]

TL;DR

Render recovered node execution status similarly to succeeded

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

flyteorg/flyte#1151

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@584536f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #177   +/-   ##
=========================================
  Coverage          ?   70.28%           
=========================================
  Files             ?      340           
  Lines             ?     6747           
  Branches          ?     1127           
=========================================
  Hits              ?     4742           
  Misses            ?     2005           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584536f...491d336. Read the comment docs.

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@katrogan katrogan merged commit 91695f8 into master Jul 23, 2021
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anrusina anrusina deleted the recovered branch January 13, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants