fix: default to not showing errors for WaitForQuery #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobNisco
approved these changes
Jan 15, 2021
Closed
13 tasks
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jan 15, 2021
## [0.19.4](http://github.com/lyft/flyteconsole/compare/v0.19.3...v0.19.4) (2021-01-15) ### Bug Fixes * default to not showing errors for WaitForQuery ([#146](http://github.com/lyft/flyteconsole/issues/146)) ([62e7ab3](http://github.com/lyft/flyteconsole/commit/62e7ab3a2fd612a2d6fa50bdf4f2693ea314c275))
|
🎉 This PR is included in version 0.19.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#673
This updates WaitForQuery to render no content by default on errors (it still logs to the console) and updates the few cases where we do want to show an error to pass in a
DataErrorcomponent.This fixes cases where we have small areas of the UI showing huge
DataErrorcomponents because they were waiting on a query that failed.Before
After
