Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining cleanup for execution-data-refactor branch #133

Merged
merged 8 commits into from
Jan 5, 2021

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Jan 5, 2021

This takes care of all the remaining TODOs for the execution-data-refactor branch, preparing it for merging to master.

  • Updated storybook stories for NodeExecutionsTable to use mock-service-worker for fake data
  • Updated storybook setup to use main/preview files instead of the single config.js and made some changes to allow using mock-service-worker in stories.
  • Updated TaskExecutionDetails page to use react-query for loading the top level TaskExecution.
  • Updated WaitForQuery to render an optional loadingComponent. Updated ExecutionDetails and TaskExecutionDetails to pass a loading spinner
  • Updated LoadingSpinner to add a 1 second delay before rendering to avoid a quick flash of content in cases where the data returns quickly.
  • Added pre-bound variants for LoadingSpinner to enable cleaner usage when passing it as a loadingComponent to WaitForQuery.
  • Added support to mock server for inserting and fetching launch plans
  • Added support to mock server for returning an error when listing node executions
  • Added handling to NodeExecutionRow to render an inline error icon when we fail to execute the query for fetching children. This is a clickable button that will initiate a refetch when clicked (and show a loading spinner while refetching)
  • Added loading skeletons for a few items
  • Added ability to disable react-query logger in tests to prevent console.error output in cases of expected failure.
  • Cleaned up other various TODOs that were either invalid or converted to a future issue.

@schottra schottra requested review from BobNisco and podehnal January 5, 2021 22:13
@schottra schottra merged commit 66fff16 into execution-data-refactor Jan 5, 2021
@schottra schottra deleted the cleanup branch January 5, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants