Remaining cleanup for execution-data-refactor branch #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of all the remaining TODOs for the execution-data-refactor branch, preparing it for merging to master.
mock-service-worker
for fake dataconfig.js
and made some changes to allow usingmock-service-worker
in stories.TaskExecutionDetails
page to use react-query for loading the top level TaskExecution.WaitForQuery
to render an optional loadingComponent. UpdatedExecutionDetails
andTaskExecutionDetails
to pass a loading spinnerLoadingSpinner
to add a 1 second delay before rendering to avoid a quick flash of content in cases where the data returns quickly.LoadingSpinner
to enable cleaner usage when passing it as aloadingComponent
toWaitForQuery
.NodeExecutionRow
to render an inline error icon when we fail to execute the query for fetching children. This is a clickable button that will initiate a refetch when clicked (and show a loading spinner while refetching)