fix: unable to submit after fixing validation errors #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnsblue
approved these changes
Oct 23, 2020
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Oct 23, 2020
## [0.16.2](http://github.com/lyft/flyteconsole/compare/v0.16.1...v0.16.2) (2020-10-23) ### Bug Fixes * missing state transition when fixing Launch validation errors ([#114](http://github.com/lyft/flyteconsole/issues/114)) ([e8173f6](http://github.com/lyft/flyteconsole/commit/e8173f6b7eeec26554ccb062bb6f9c657ce410b9))
|
🎉 This PR is included in version 0.16.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
There was a missing state transition between the invalid inputs state and the submission/validation state, causing the state machine to do nothing when attempting to submit after fixing validation errors. The fix just required adding an allowed state transition and corresponding unit tests.
Type
Are all requirements met?
Complete description
N/A
Tracking Issue
flyteorg/flyte#565