Skip to content

Commit

Permalink
fix: fix final nits
Browse files Browse the repository at this point in the history
Signed-off-by: Olga Nad <[email protected]>
  • Loading branch information
olga-union committed May 12, 2022
1 parent 98e870b commit f7b7f54
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export const MapTaskExecutionsListItem: React.FC<MapTaskExecutionsListItemProps>
if (!logs) {
return null;
}
const key = `${id}-${phase}-${selectedPhase}`;
const key = `${id}-${phase}`;
return (
<MapTaskStatusInfo
phase={phase}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const ReactFlowGraphComponent = (props) => {
onPhaseSelectionChanged,
rfGraphJson: null,
});
// const [nodeExecutionUpdateCount, setNodeExecutionUpdateCount] = useState<number>(0);

const onAddNestedView = (view) => {
const currentView = state.currentNestedView[view.parent] || [];
const newView = {
Expand Down Expand Up @@ -101,24 +101,12 @@ const ReactFlowGraphComponent = (props) => {

useEffect(() => {
const newRFGraphData = buildReactFlowGraphData();
// console.log('CLO ~ useEffect ~ newRFGraphData', newRFGraphData);
setState((state) => ({
...state,
rfGraphJson: newRFGraphData,
}));
}, [state.currentNestedView, state.nodeExecutionsById]);

// useEffect(() => {
// if (nodeExecutionUpdateCount < 2) {
// const newRFGraphData = buildReactFlowGraphData();
// setState((state) => ({
// ...state,
// rfGraphJson: newRFGraphData,
// }));
// setNodeExecutionUpdateCount(nodeExecutionUpdateCount + 1);
// }
// }, [state.nodeExecutionsById]);

useEffect(() => {
if (graphNodeCountChanged(state.data, data)) {
setState((state) => ({
Expand Down

0 comments on commit f7b7f54

Please sign in to comment.