fix: revert node version (#704)

* fix: revert node version Signed-off-by: Carina Ursu <[email protected]> * Revert "fix: upgrading node version to 18 (#703)" This reverts commit e5f9a8b. Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]>
flyteorg · Mar 6, 2023 · c075f4f · c075f4f
1 parent e5f9a8b
commit c075f4f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -31,7 +31,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v2
         with:
-          node-version: 18
+          node-version: 16
       - uses: bahmutov/npm-install@v1
       - name: Run tests and generate coverage
         run: make test_unit_codecov
@@ -46,7 +46,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: 18
+          node-version: 16
       - uses: bahmutov/npm-install@v1
       - name: Run linter
         run: make lint
@@ -66,21 +66,15 @@ jobs:
   release:
     name: Generate Release
     if: ${{ (github.event_name != 'pull_request') && (needs.extract_branch.outputs.branch == 'master') }}
-    needs:
-      [
-        unit_tests_with_coverage,
-        lint_project,
-        build_docker_image,
-        extract_branch,
-      ]
+    needs: [unit_tests_with_coverage, lint_project, build_docker_image, extract_branch]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v2
       - name: Setup Node.js
         uses: actions/setup-node@v1
         with:
-          node-version: 18
+          node-version: 16
       - name: Install dependencies
         run: yarn install --frozen-lockfile
       - name: Release
@@ -119,7 +113,7 @@ jobs:
   push_docker_image:
     name: Build & Push FlyteConsole Image
     if: ${{ needs.check_for_tag.outputs.currentTag != '' }}
-    needs: [check_for_tag]
+    needs: [ check_for_tag ]
     uses: flyteorg/flytetools/.github/workflows/publish.yml@master
     with:
       before-build: |

diff --git a/.tool-versions b/.tool-versions
@@ -1,2 +1,2 @@
-nodejs 18.1.0
-yarn 3.2.1
+nodejs 16.18.0
+yarn 3.2.1
diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,5 @@
 # syntax=docker/dockerfile:experimental
-FROM node:18.1.0 as builder
+FROM node:16 as builder
 
 LABEL org.opencontainers.image.source https://github.com/flyteorg/flyteconsole