fix: fix failing tests

Signed-off-by: Pianist038801 <[email protected]>
flyteorg · Oct 26, 2021 · be5ee74 · be5ee74
1 parent ce64ae9
commit be5ee74
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/components/Executions/ExecutionFilters.tsx b/src/components/Executions/ExecutionFilters.tsx
@@ -60,16 +60,16 @@ const RenderFilter: React.FC<{ filter: FilterState }> = ({ filter }) => {
  */
 export const ExecutionFilters: React.FC<{
     filters: (FilterState | BooleanFilterState)[];
-    chartIds: string[];
-    clearCharts: () => void;
+    chartIds?: string[];
+    clearCharts?: () => void;
 }> = ({ filters, chartIds, clearCharts }) => {
     const styles = useStyles();
 
     filters = filters.map(filter => {
         const onChangeFunc = filter.onChange;
         filter.onChange = value => {
-            clearCharts();
-            onChangeFunc(value);
+            if (clearCharts) clearCharts();
+            if (onChangeFunc) onChangeFunc(value);
         };
         return filter;
     });
@@ -113,7 +113,7 @@ export const ExecutionFilters: React.FC<{
                     />
                 );
             })}
-            {chartIds.length > 0 && (
+            {chartIds && chartIds.length > 0 && (
                 <FilterPopoverButton
                     open={false}
                     active={true}

diff --git a/src/components/Executions/filters/types.ts b/src/components/Executions/filters/types.ts
@@ -31,6 +31,7 @@ export interface FilterState {
     status?: string;
     getFilter: () => FilterOperation[];
     onReset: () => void;
+    onChange?: (value) => void;
 }
 
 export interface SingleFilterState<FilterKey extends string>