-
Notifications
You must be signed in to change notification settings - Fork 59
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: fetch child node executions for NodeExecution rows (#72)
* refactor: fetch child node executions to determine expandability * fix: handling detection of children for sub-workflows as well * fix: poor performance with object-hash on some identifiers * docs: cleanup and docs for newly exposed functions * test: ensure request config is used for all levels * chore: remove unused import
- Loading branch information
Showing
10 changed files
with
275 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| import { APIContextValue, useAPIContext } from 'components/data/apiContext'; | ||
| import { | ||
| FetchableData, | ||
| fetchNodeExecutions, | ||
| fetchTaskExecutionChildren | ||
| } from 'components/hooks'; | ||
| import { useFetchableData } from 'components/hooks/useFetchableData'; | ||
| import { isEqual } from 'lodash'; | ||
| import { | ||
| NodeExecution, | ||
| RequestConfig, | ||
| TaskExecutionIdentifier, | ||
| WorkflowExecutionIdentifier | ||
| } from 'models'; | ||
| import * as React from 'react'; | ||
| import { ExecutionContext } from './ExecutionDetails/contexts'; | ||
| import { formatRetryAttempt } from './TaskExecutionsList/utils'; | ||
| import { NodeExecutionGroup } from './types'; | ||
| import { fetchTaskExecutions } from './useTaskExecutions'; | ||
|
|
||
| interface FetchGroupForTaskExecutionArgs { | ||
| apiContext: APIContextValue; | ||
| config: RequestConfig; | ||
| taskExecutionId: TaskExecutionIdentifier; | ||
| } | ||
| async function fetchGroupForTaskExecution({ | ||
| apiContext, | ||
| config, | ||
| taskExecutionId | ||
| }: FetchGroupForTaskExecutionArgs): Promise<NodeExecutionGroup> { | ||
| return { | ||
| // NodeExecutions created by a TaskExecution are grouped | ||
| // by the retry attempt of the task. | ||
| name: formatRetryAttempt(taskExecutionId.retryAttempt), | ||
| nodeExecutions: await fetchTaskExecutionChildren( | ||
| { config, taskExecutionId }, | ||
| apiContext | ||
| ) | ||
| }; | ||
| } | ||
|
|
||
| interface FetchGroupForWorkflowExecutionArgs { | ||
| apiContext: APIContextValue; | ||
| config: RequestConfig; | ||
| workflowExecutionId: WorkflowExecutionIdentifier; | ||
| } | ||
| async function fetchGroupForWorkflowExecution({ | ||
| apiContext, | ||
| config, | ||
| workflowExecutionId | ||
| }: FetchGroupForWorkflowExecutionArgs): Promise<NodeExecutionGroup> { | ||
| return { | ||
| // NodeExecutions created by a workflow execution are grouped | ||
| // by the execution id, since workflow executions are not retryable. | ||
| name: workflowExecutionId.name, | ||
| nodeExecutions: await fetchNodeExecutions( | ||
| { config, id: workflowExecutionId }, | ||
| apiContext | ||
| ) | ||
| }; | ||
| } | ||
|
|
||
| interface FetchNodeExecutionGroupArgs { | ||
| apiContext: APIContextValue; | ||
| config: RequestConfig; | ||
| nodeExecution: NodeExecution; | ||
| } | ||
|
|
||
| async function fetchGroupsForTaskExecutionNode({ | ||
| apiContext, | ||
| config, | ||
| nodeExecution: { id: nodeExecutionId } | ||
| }: FetchNodeExecutionGroupArgs): Promise<NodeExecutionGroup[]> { | ||
| const taskExecutions = await fetchTaskExecutions( | ||
| nodeExecutionId, | ||
| apiContext | ||
| ); | ||
|
|
||
| return await Promise.all( | ||
| taskExecutions.map(({ id: taskExecutionId }) => | ||
| fetchGroupForTaskExecution({ apiContext, config, taskExecutionId }) | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| async function fetchGroupsForWorkflowExecutionNode({ | ||
| apiContext, | ||
| config, | ||
| nodeExecution | ||
| }: FetchNodeExecutionGroupArgs): Promise<NodeExecutionGroup[]> { | ||
| if (!nodeExecution.closure.workflowNodeMetadata) { | ||
| throw new Error('Unexpected empty `workflowNodeMetadata`'); | ||
| } | ||
| const { | ||
| executionId: workflowExecutionId | ||
| } = nodeExecution.closure.workflowNodeMetadata; | ||
| // We can only have one WorkflowExecution (no retries), so there is only | ||
| // one group to return. But calling code expects it as an array. | ||
| return [ | ||
| await fetchGroupForWorkflowExecution({ | ||
| apiContext, | ||
| config, | ||
| workflowExecutionId | ||
| }) | ||
| ]; | ||
| } | ||
|
|
||
| /** Fetches and groups `NodeExecution`s which are direct children of the given | ||
| * `NodeExecution`. | ||
| */ | ||
| export function useChildNodeExecutions( | ||
| nodeExecution: NodeExecution, | ||
| config: RequestConfig | ||
| ): FetchableData<NodeExecutionGroup[]> { | ||
| const apiContext = useAPIContext(); | ||
| const { workflowNodeMetadata } = nodeExecution.closure; | ||
| const { execution: topExecution } = React.useContext(ExecutionContext); | ||
| return useFetchableData<NodeExecutionGroup[], NodeExecution>( | ||
| { | ||
| debugName: 'ChildNodeExecutions', | ||
| defaultValue: [], | ||
| doFetch: async data => { | ||
| const fetchArgs = { | ||
| apiContext, | ||
| config, | ||
| nodeExecution: data | ||
| }; | ||
| // Nested NodeExecutions will sometimes have `workflowNodeMetadata` that | ||
| // points to the parent WorkflowExecution. We're only interested in | ||
| // showing children if this node is a sub-workflow. | ||
| if ( | ||
| workflowNodeMetadata && | ||
| !isEqual(workflowNodeMetadata.executionId, topExecution.id) | ||
| ) { | ||
| return fetchGroupsForWorkflowExecutionNode(fetchArgs); | ||
| } | ||
| return fetchGroupsForTaskExecutionNode(fetchArgs); | ||
| } | ||
| }, | ||
| nodeExecution | ||
| ); | ||
| } |
Oops, something went wrong.