This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
feature; Flyte Copilot and dataloading config added to core protos #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumare3
requested review from
anandswaminathan,
EngHabu,
katrogan,
matthewphsmith and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 63.14% 63.14%
=======================================
Files 100 100
Lines 7038 7038
=======================================
Hits 4444 4444
Misses 2082 2082
Partials 512 512 Continue to review full report at Codecov.
|
katrogan
reviewed
May 18, 2020
go.mod
Outdated
| github.com/lyft/flytepropeller v0.2.13 | ||
| github.com/lyft/flytestdlib v0.3.2 | ||
| github.com/lyft/flyteidl v0.17.31 | ||
| github.com/lyft/flytepropeller v0.2.39-0.20200517212313-457679106bf2 |
There was a problem hiding this comment.
is this a release version?
There was a problem hiding this comment.
not yet, will be releasing soon
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 63.24% 63.24%
=======================================
Files 101 101
Lines 7465 7465
=======================================
Hits 4721 4721
Misses 2197 2197
Partials 547 547
Continue to review full report at Codecov.
|
kumare3
changed the title
katrogan
approved these changes
Jun 23, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Update FlyteAdmin to use latest FlyteIDL
Type
Are all requirements met?
Complete description
Refer to Design Doc
Tracking Issue
flyteorg/flyte#297
Follow-up issue
flyteorg/flyte#316
flyteorg/flyte#317