This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Push to dockerhub on merge to master & readd integration tests #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
anandswaminathan,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
wild-endeavor
previously approved these changes
Jan 24, 2020
wild-endeavor
approved these changes
Jan 27, 2020
.travis.yml
Outdated
| install: true | ||
| script: BUILD_PHASE=builder make docker_build | ||
| script: BUILD_PHASE=builder make docker_build && make k8s_integration && make dockerhub_push |
There was a problem hiding this comment.
but we'll get rid of this right?
There was a problem hiding this comment.
i thought we didn't want to push to dockerhub on PRs. On PRs, we build the image each time and run integration tests using that image, and then discard it. Only on merge to master do we actually push to Dockerhub. Or did we change our minds? I don't remember.
There was a problem hiding this comment.
this is if fork = false
There was a problem hiding this comment.
oh that's what that does? cool
There was a problem hiding this comment.
ugh forget it, i'll figure out creds to push in another pr
wild-endeavor
previously approved these changes
Jan 27, 2020
wild-endeavor
approved these changes
Jan 27, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.