This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Tiny url improvements #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 58.51% 60.13% +1.62%
==========================================
Files 168 168
Lines 16174 13285 -2889
==========================================
- Hits 9464 7989 -1475
+ Misses 5871 4454 -1417
- Partials 839 842 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wild-endeavor
requested review from
katrogan,
EngHabu,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
previously approved these changes
May 18, 2023
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…n into tiny-url-improvements
pingsutw
previously approved these changes
May 22, 2023
eapolinario
previously approved these changes
May 22, 2023
dataproxy/service.go
Outdated
| return nil, errors.NewFlyteAdminErrorf(codes.InvalidArgument, "failed to validate resolve artifact request. Error: %v", err) | ||
| } | ||
|
|
||
| executions, err := common.ParseFlyteURLToExecution(req.GetFlyteUrl()) |
There was a problem hiding this comment.
nit: why is this in the plural?
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
May 23, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This adds the ability to return an individual input or output in the flyte url, e.g.
There's currently no mechanism by which these URLs can be returned to the frontend however. This can be worked on separately.
Type
Are all requirements met?
Complete description
Tracking Issue
NA