Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add migration to turn parent_id column into bigint only if necess… #560

Closed
wants to merge 3 commits into from

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented May 10, 2023

Please see #561 instead. This was closed because the branch name was the same as the tag we wanted to create.

…ary (#554)

* Add migration to turn `parent_id` column into `bigint` only if necessary

Signed-off-by: eduardo apolinario <[email protected]>

* Migrations to handle the change of `parent_id` column in `node_executions` table

Signed-off-by: eduardo apolinario <[email protected]>

* Add unit test

Signed-off-by: eduardo apolinario <[email protected]>

* More coverage

Signed-off-by: eduardo apolinario <[email protected]>

* Create index outside transaction

Signed-off-by: eduardo apolinario <[email protected]>

---------

Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #560 (b3924de) into release-v1.1.88 (eb695b1) will decrease coverage by 0.38%.
The diff coverage is 12.06%.

❗ Current head b3924de differs from pull request most recent head 7239413. Consider uploading reports for the commit 7239413 to get more accurate results

@@                 Coverage Diff                 @@
##           release-v1.1.88     #560      +/-   ##
===================================================
- Coverage            58.85%   58.48%   -0.38%     
===================================================
  Files                  170      170              
  Lines                16068    16184     +116     
===================================================
+ Hits                  9457     9465       +8     
- Misses                5777     5883     +106     
- Partials               834      836       +2     
Flag Coverage Δ
unittests 58.48% <12.06%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repositories/config/migrations.go 2.68% <12.06%> (+1.54%) ⬆️

... and 1 file with indirect coverage changes

@wild-endeavor wild-endeavor deleted the v1.1.88.1 branch May 11, 2023 04:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants