This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Save CheckpointUri in NodeExecution.Closure #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Dye <[email protected]>
andrewwdye
requested review from
katrogan,
wild-endeavor,
anandswaminathan,
EngHabu,
kumare3 and
pmahindrakar-oss
as code owners
8 tasks
Signed-off-by: Andrew Dye <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
+ Coverage 61.55% 61.61% +0.05%
==========================================
Files 158 158
Lines 11490 11492 +2
==========================================
+ Hits 7073 7081 +8
+ Misses 3683 3677 -6
Partials 734 734
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…o node-execution-checkpoints Signed-off-by: Andrew Dye <[email protected]>
katrogan
approved these changes
Oct 5, 2022
hamersaw
approved these changes
Oct 6, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Save CheckpointUri in NodeExecution.Closure Signed-off-by: Andrew Dye <[email protected]> * Test failures Signed-off-by: Andrew Dye <[email protected]> Signed-off-by: Andrew Dye <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Dye [email protected]
TL;DR
This changes saves the checkpoint path in the
NodeExecutionModelso that we have it when recovering a workflow. Previously intra task checkpointing was only supported for task level retries within a single node execution.Related PR: flyteorg/flytepropeller#486
Type
Are all requirements met?
Complete description
This change adds
CheckpointUrito theNodeExecutionModelstored in the admin db, as part ofTaskNodeMetadatain theClosure.Testing
See flyteorg/flytepropeller#486 for end-to-end testing strategy
Tracking Issue
flyteorg/flyte#2254
Follow-up issue
NA