Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Pass along raw claims in identity context #447

Merged
merged 10 commits into from
Jun 16, 2022
Merged

Conversation

katrogan
Copy link
Contributor

TL;DR

Follow-up to improve flexibility of customizable auth plugins

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

fixes flyteorg/flyte#2607

Follow-up issue

NA

katrogan added 5 commits June 10, 2022 16:10
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
katrogan added 2 commits June 15, 2022 16:03
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #447 (09c31cb) into master (0b9bf4e) will increase coverage by 0.16%.
The diff coverage is 75.29%.

❗ Current head 09c31cb differs from pull request most recent head 948e08a. Consider uploading reports for the commit 948e08a to get more accurate results

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   61.36%   61.53%   +0.16%     
==========================================
  Files         157      157              
  Lines       11205    11223      +18     
==========================================
+ Hits         6876     6906      +30     
+ Misses       3615     3603      -12     
  Partials      714      714              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth/config/config.go 71.42% <ø> (ø)
auth/token.go 0.00% <0.00%> (ø)
...g/manager/impl/validation/launch_plan_validator.go 63.54% <0.00%> (-2.05%) ⬇️
pkg/repositories/errors/postgres.go 80.48% <ø> (ø)
pkg/manager/impl/validation/execution_validator.go 73.80% <33.33%> (-1.50%) ⬇️
auth/handlers.go 31.14% <50.00%> (ø)
auth/cookie_manager.go 56.75% <66.66%> (-1.51%) ⬇️
auth/identity_context.go 64.28% <83.33%> (+34.55%) ⬆️
pkg/repositories/database.go 44.31% <83.33%> (+6.11%) ⬆️
...manager/impl/validation/notifications_validator.go 84.00% <84.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9bf4e...948e08a. Read the comment docs.

@katrogan katrogan marked this pull request as ready for review June 15, 2022 23:34
Signed-off-by: Katrina Rogan <[email protected]>
EngHabu
EngHabu previously approved these changes Jun 16, 2022
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan dismissed stale reviews from pmahindrakar-oss and EngHabu via a132394 June 16, 2022 17:06
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan merged commit b29605d into master Jun 16, 2022
@katrogan katrogan deleted the jwt-token-passing-along branch June 16, 2022 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Expose raw claims in auth IdentityContext
3 participants