This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Auth cookie domain #440
Merged
Auth cookie domain #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmahindrakar-oss
requested review from
katrogan,
wild-endeavor,
anandswaminathan,
EngHabu and
kumare3
as code owners
EngHabu
reviewed
Jun 6, 2022
| if !c.coverSubDomains { | ||
| return "" | ||
| } | ||
| return fmt.Sprintf(".%s", request.URL.Hostname()) |
There was a problem hiding this comment.
nice! I guess this works because this is an HTTP request not a GRPC request...
Have you tried it behind an ingress? mind doing that?
There was a problem hiding this comment.
Tested this both with grpc endpoints through flytectl and through flyteconsole and no issues were discovered
auth/config/config.go
Outdated
| } | ||
|
|
||
| type CookieSettings struct { | ||
| SameSite http.SameSite `json:"sameSite" pflag:",OPTIONAL: Allows you to declare if your cookie should be restricted to a first-party or same-site context."` |
There was a problem hiding this comment.
Does this parse well from a yaml config?
There was a problem hiding this comment.
It does if we pass int values. But added an enum wrapper for good UX.
ursucarina
previously approved these changes
Jun 6, 2022
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
force-pushed
the
auth-cookie-domain
branch
from
e9723d4 to
58be79a
Compare
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
+ Coverage 61.35% 61.39% +0.04%
==========================================
Files 156 158 +2
Lines 11111 11181 +70
==========================================
+ Hits 6817 6865 +48
- Misses 3589 3607 +18
- Partials 705 709 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
EngHabu
approved these changes
Jun 7, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Adding domain to secure auth cookies Signed-off-by: Prafulla Mahindrakar <[email protected]> * Adding . suffix to the domain Signed-off-by: Prafulla Mahindrakar <[email protected]> * Add getCookiedomain Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added enumers for domainMatch and sameSite and testing done Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added debug make targets for admin and scheduler Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more coverage Signed-off-by: Prafulla Mahindrakar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Allow user of flyteadmin to specify the cookie settings of there flyteadmin user auth cookies
Allowing subdomain access by setting the domain field in the cookie
and allowing to set SameSite preference to allow firstparty or thirdparty cookies to be sent from the browser.
Mode changes are applicable for only the following cookies
One thing i noticed is that dot prefix gets subsituted by the browser seems like .
source : http://bayou.io/draft/cookie.domain.html
So i didn't find any behavior change with domain setting policy for localhost or hosted.cloud-staging.union.ai
Testing done :
With LAX mode for auth cookies
With Strict mode for auth cookies
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes flyteorg/flyte#2596
Follow-up issue
NA