This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
add server reflection #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kumare3 PTAL |
|
@honnix can you add this behind a config flag? I'm not sure if it has implications on performance/security... etc. |
|
+1 to making configurable |
|
This seems like a standard part of GRCP protocol and I didn't find any thing around performance hit and security. But sure, we can have a config flag. BTW I did the same to datacatalog and it was already merged. I will send a follow up PR to make it configurable. |
|
sorry for the back and forth - could you add grpcServerReflection: true to the config file at the base of the repo please? It's meant to be the config that one would use when running locally ( Thanks! |
wild-endeavor
approved these changes
Nov 25, 2019
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
The same as flyteorg/datacatalog#19 With [server reflection](https://github.com/grpc/grpc-go/blob/master/Documentation/server-reflection-tutorial.md), it would be easier to interact with GRPC service using e.g. `grpcurl`. flyteadmin does come with HTTP endpoint as well, but interacting with GRPC directly makes it more handy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as flyteorg/datacatalog#19
With server reflection, it would be easier to interact with GRPC service using e.g.
grpcurl.flyteadmin does come with HTTP endpoint as well, but interacting with GRPC directly makes it more handy.