Added default admin config for MaxParallelism

[pmahindrakar-oss]

Signed-off-by: Prafulla Mahindrakar [email protected]

TL;DR

Workflow executions can be gated by the max number of parallel nodes that can be processed. Specific override support for this MaxParallelism value already exists but not a generic default in the FlyteAdmin config.

This PR adds support in the admin config and provides a default value of 25
Following is the order in which property override is checked

• launchplan spec override
• matchable resource attribute override
• admin application config override (defaults to 25 or else uses the configured value)

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#1532

Follow-up issue

NA

[codecov]

Codecov Report

Merging #262 (fd11329) into master (5c86bbe) will increase coverage by 0.08%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   57.47%   57.55%   +0.08%     
==========================================
  Files         141      143       +2     
  Lines       10481    10553      +72     
==========================================
+ Hits         6024     6074      +50     
- Misses       3787     3809      +22     
  Partials      670      670              

Flag	Coverage Δ
unittests	56.36% <27.27%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/rpc/adminservice/base.go	3.53% <0.00%> (ø)
pkg/runtime/application_config_provider.go	5.88% <ø> (ø)
pkg/manager/impl/execution_manager.go	71.29% <100.00%> (+0.05%)	⬆️
pkg/repositories/transformers/project.go	72.22% <0.00%> (-14.45%)	⬇️
pkg/async/notifications/factory.go	3.52% <0.00%> (-0.36%)	⬇️
pkg/manager/impl/validation/project_validator.go	100.00% <0.00%> (ø)
...g/async/notifications/implementations/processor.go
...ync/notifications/implementations/aws_processor.go	65.67% <0.00%> (ø)
...notifications/implementations/processor_metrics.go	100.00% <0.00%> (ø)
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c86bbe...fd11329. Read the comment docs.

[EngHabu]

LGTM. Maybe get one more from Katrina?

[katrogan]

can we set a sensible default here: https://github.com/flyteorg/flyteadmin/blob/master/pkg/runtime/application_config_provider.go#L39

@kumare3 what sounds good? 100?

[pmahindrakar-oss]

@katrogan its already set to 25 which was discussed in the slack chat . Let me know if we need a different default value

[pmahindrakar-oss]

Have kept this as default for now .
cc : @katrogan @kumare3

[katrogan]

oh thanks! i missed this earlier