Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add NodeExecutionPhase.RECOVERED as a terminal phase #224

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

katrogan
Copy link
Contributor

Signed-off-by: Katrina Rogan [email protected]

TL;DR

Missed this in #220 - without this patch we never record the node execution outputs.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#1151

Follow-up issue

NA

Signed-off-by: Katrina Rogan <[email protected]>
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #224 (a4c93a7) into master (0a4ac6a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   57.06%   57.06%           
=======================================
  Files         135      135           
  Lines       10117    10117           
=======================================
  Hits         5773     5773           
  Misses       3698     3698           
  Partials      646      646           
Flag Coverage Δ
unittests 55.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/common/executions.go 53.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4ac6a...a4c93a7. Read the comment docs.

@katrogan katrogan merged commit be0aa2c into master Jul 28, 2021
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants