This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Support signed URL's from minio. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2019 18:29
|
+1 |
jonathanburns
approved these changes
Oct 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we return data from the Admin server as signed URLs. Flyte in its sandbox environment uses minio. Minio support the AWS SDK completely, but needs a couple more settings. support for signed url existed for AWS S3, this change adds it for Minio.
NOTE: Other cloud providers are not really supported. They return a plain url.
TODO: migrate this API to flytestdlib and normalize across all cloud providers. We should have an alternate api that could return the literalmap - decoded (and it could use the size as a limiting factor)