This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Support plugin override matchable resource #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change introduces adding plugin overrides to the flyte workflow CRD when they exist for a matching CreateExecutionRequest.
Additionally, this change also adds a logical merge functionality for plugin overrides so that individual users do not have to do a get before update. Rather, any task type plugin overrides they specify will be saved in addition to existing overrides for other task types. The admin-internal sequence for get & update is not transactional and this could cause small errors to arise, but since system administrators will be infrequently calling the master update endpoint this should not really be a concern.
Type
Are all requirements met?
Complete description
https://docs.google.com/document/d/1OWYJ2ggr0pWvOdOKkf04NLtj2Rf32dMVYvAYMoyeU48/edit?usp=sharing
Tracking Issue
flyteorg/flyte#499
Follow-up issue
NA