This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add UpdateProject functionality to Flyte control plane #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosigz-lyft
requested review from
anandswaminathan,
EngHabu,
katrogan,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
|
Can you create an issue in github.com/flyte/issues (it's public) and link all of these PRs to it? |
kumare3
reviewed
Aug 13, 2020
katrogan
reviewed
Aug 13, 2020
katrogan
reviewed
Aug 13, 2020
katrogan
reviewed
Aug 13, 2020
kosigz-lyft
changed the title
8 tasks
|
Mind adding an integration test here: https://github.com/lyft/flyteadmin/blob/master/tests/project.go to validate the Update works to only overwrite set fields? |
katrogan
reviewed
Aug 17, 2020
katrogan
reviewed
Aug 18, 2020
katrogan
reviewed
Aug 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 62.50% 62.32% -0.19%
==========================================
Files 104 104
Lines 7722 7753 +31
==========================================
+ Hits 4827 4832 +5
- Misses 2327 2351 +24
- Partials 568 570 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
katrogan
reviewed
Aug 18, 2020
katrogan
reviewed
Aug 18, 2020
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
katrogan
reviewed
Aug 18, 2020
katrogan
reviewed
Aug 18, 2020
… update_project_repo
katrogan
reviewed
Aug 18, 2020
katrogan
approved these changes
Aug 19, 2020
|
@katrogan thanks for helping me through it! There's no way I could have shipped this feature without your guidance. 😄 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* introduce pr to update project repo * wip * wip * wip + merge * wip + compiles woot woot * don't return types where unused; db write * check for writeTx error * interface * use get * add first integration test * cmts * fix * new integration test * ci * apologies for all the commits; running CI off GitHub * nit * api update * update mock interface * wip * mock update * lol * bump back some dependencies * dep * unit test and migration * protobuf * should be last dep change * revert go.mode and make compile * mock out more things, fix white space * wip * wip * gofmt * project * Update pkg/repositories/gormimpl/project_repo.go Co-authored-by: Katrina Rogan <[email protected]> * Update pkg/repositories/gormimpl/project_repo.go Co-authored-by: Katrina Rogan <[email protected]> * cmnts * truncate tables before tests * update integration test * integration test * := Co-authored-by: Konstantin Gizdarski <[email protected]> Co-authored-by: Katrina Rogan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add UpdateProject functionality to Flyte control plane.
Type
Issue
flyteorg/flyte#474
Are all requirements met?