Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Pass RawOutputDataConfig if set on the LP #112

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Aug 10, 2020

TL;DR

Set RawOutputDataConfig in the generated WF CRD.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

flyteorg/flyte#211

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020

Codecov Report

Merging #112 into master will decrease coverage by 0.11%.
The diff coverage is 51.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   62.51%   62.40%   -0.12%     
==========================================
  Files         104      104              
  Lines        7601     7652      +51     
==========================================
+ Hits         4752     4775      +23     
- Misses       2292     2314      +22     
- Partials      557      563       +6     
Flag Coverage Δ
#unittests 62.40% <51.72%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repositories/config/migrations.go 0.00% <0.00%> (ø)
pkg/workflowengine/impl/propeller_executor.go 51.23% <0.00%> (-0.97%) ⬇️
pkg/manager/impl/node_execution_manager.go 66.53% <54.83%> (-2.30%) ⬇️
pkg/repositories/transformers/node_execution.go 69.79% <68.75%> (-0.13%) ⬇️
pkg/repositories/gormimpl/node_execution_repo.go 62.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd98d4...f431f7f. Read the comment docs.

wild-endeavor
wild-endeavor previously approved these changes Aug 10, 2020
@EngHabu EngHabu merged commit 4aa1178 into master Aug 12, 2020
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Pass RawOutputDataConfig if set on the LP

* Update to released propeller version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants