Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
Remove single task execution default timeout (#564)
Browse files Browse the repository at this point in the history
* removed default timeout

Signed-off-by: Daniel Rammer <[email protected]>

* removed unnecessary dependencies

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw authored May 17, 2023
1 parent a853dac commit 062641f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/manager/impl/util/single_task_execution.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"fmt"
"strings"
"time"
"unicode"

"github.com/flyteorg/flyteadmin/pkg/errors"
Expand All @@ -17,7 +16,6 @@ import (
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin"
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/core"
"github.com/flyteorg/flytestdlib/logger"
"github.com/golang/protobuf/ptypes"
"google.golang.org/grpc/codes"
)

Expand All @@ -26,7 +24,6 @@ const maxNodeIDLength = 63
var defaultRetryStrategy = core.RetryStrategy{
Retries: 3,
}
var defaultTimeout = ptypes.DurationProto(24 * time.Hour)

const systemNamePrefix = ".flytegen.%s"

Expand Down Expand Up @@ -102,7 +99,6 @@ func CreateOrGetWorkflowModel(
Metadata: &core.NodeMetadata{
Name: generateNodeNameFromTask(taskIdentifier.Name),
Retries: &defaultRetryStrategy,
Timeout: defaultTimeout,
},
Inputs: generateBindings(*task.Closure.CompiledTask.Template.Interface.Inputs, noInputNodeID),
Target: &core.Node_TaskNode{
Expand Down

0 comments on commit 062641f

Please sign in to comment.