Helm chart with dependencies #784

sbrunk · 2021-03-01T09:57:57Z

This is based on the work of @rstanevich in #550 with the following changes:

Use external chart dependencies (for contour and spark-operator for now)
Bump image versions
Rebased against master

Draft PR so people can try it and as a basis for discussion about the chart.

I.e. should we also use dependencies for minio and postgres
Should we use subcharts for components
What things need to be more customizable
etc.

kumare3 · 2021-03-03T19:13:21Z

Is this ready for review?

sbrunk · 2021-03-10T16:59:25Z

Not yet. There are still some issues with the spark operator I need to investigate. I'm starting to look into this again now.

kumare3 · 2021-04-09T16:21:18Z

helm/README.MD

+
+## Values
+
+| Key | Type | Default | Description |


ohh man this is crazy, maintaining this will be a nightmare right? We need to auto-generate this

Completely agree. Looking at 6517fbb it seems it's already autogenerated

@rstanevich did you use https://github.com/norwoodj/helm-docs?

@sbrunk
Yes, this README is autogenerated using the helm plugin https://github.com/norwoodj/helm-docs and template file https://github.com/flyteorg/flyte/blob/125710b4c2b23a0a39e794a0761c4337872467ce/helm/README.md.gotmpl

kumare3 · 2021-04-09T18:05:09Z

@sbrunk I had a question, so in Helm, is it possible to create 3 different configuration options - Flyte Low, Medium, High (performance) and we create precanned configuration. this would make configuring Flyte even easier.
so as a user one needs to provide

A postgres database
A Blob store
A K8s cluster
Optional: If you want eventing then choose the pubsub module
Optional: Choose the authentication module
Optional: choose Ingress
And then choose the performance mode: Low, medium, High

I am also working on a sharded/distributed FlytePropeller mode, the problem is config. This can help simplify

@EngHabu @jeevb what do you guys think?

kumare3 · 2021-04-09T20:50:44Z

helm/templates/minio/deployment.yaml

@@ -0,0 +1,50 @@
+{{- if .Values.minio.enabled }}


can we just use the minio helm chart as a dependency?
https://github.com/minio/charts (probably this is the old one)

Yes that should work. I think I actually looked it up and didn't add it because the repo was archived. But minio is only for sandbox anyway right?

Yup it's only sandbox- I am ok keeping it too

kumare3 · 2021-04-09T20:52:47Z

helm/templates/postgres/deployment.yaml

@@ -0,0 +1,45 @@
+{{- if .Values.postgres.enabled }}


same for postgres? https://bitnami.com/stack/postgresql/helm
I guess this is an overkill?

Yeah if deploying a postgres is only for sandbox it might be overkill.

Signed-off-by: Sören Brunk <[email protected]>

Bump versions Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize changes: - cd4a3d5 Trim sandbox (flyteorg#727) - 9b59ac6 Update propeller version and config (flyteorg#580) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize change: - 0e2dd72 Updating Spark config to force default credentials chain for AWS (flyteorg#674) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize change: - 46864a5 Access GRPC services using projectcontour (flyteorg#686) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize change: - 658aecd Enabling Event version 1 by default (flyteorg#689) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize change: - fbe7e68 Improve getting started experience (flyteorg#694) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize change: - 0844a44 Exponential error back-off in case of system errors (flyteorg#693) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize change: - cd4a3d5 Trim sandbox (flyteorg#727) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize change: - 72c5705 Update default RAM Request for tasks in sandbox (flyteorg#750) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize change: - b13de21 Update Admin task resources (flyteorg#753) Signed-off-by: Sören Brunk <[email protected]>

Based on the following kustomize changes: - a14fd47 Update deployments with latest k8s library deps (flyteorg#826) - f149af8 Add kubernetes dashboard to sandbox overlay (flyteorg#789) Signed-off-by: Sören Brunk <[email protected]>

Use default Docker images in EKS Helm values. Based on the following kustomize changes: - 4e0eed6 Update EKS Ingress and Instructions (flyteorg#825) Signed-off-by: Sören Brunk <[email protected]>

Signed-off-by: Sören Brunk <[email protected]>

kumare3 · 2021-04-13T04:48:22Z

helm/values-sandbox.yaml

+      host: postgres
+      dbname: flyte_development
+
+  storage:


I would like to change this
Have a parameter like
storage-kind: s3 | gcs | minio | custom

If custom then you provide the entire configuration, else the config is automatic?

This is now done in 151446d (in the new internal branch).

kumare3 · 2021-04-13T04:49:24Z

helm/values-sandbox.yaml

+      namespace: {{ namespace }}
+    data:
+      config.yaml: |
+        storage:


samething, is it possible to derive this from the other config, even though this is actually a string?

kumare3 · 2021-04-13T04:49:51Z

helm/values-sandbox.yaml

+        kubernetes-enabled: true
+        kubernetes-template-uri: "http://localhost:30082/#/log/{{ .namespace }}/{{ .podName }}/pod?namespace={{ .namespace }}"
+
+  logger:


What about having a simple mode called debug?

Signed-off-by: Sören Brunk <[email protected]>

sbrunk · 2021-04-22T09:47:45Z

Superseded by #916

sbrunk force-pushed the helm-chart-with-dependencies branch 2 times, most recently from ac6db54 to 5071f7e Compare March 21, 2021 12:28

sbrunk force-pushed the helm-chart-with-dependencies branch 3 times, most recently from 8047bb0 to 69e32fe Compare April 1, 2021 19:36

sbrunk marked this pull request as ready for review April 1, 2021 19:43

sbrunk mentioned this pull request Apr 1, 2021

[Feature] Convert Flyte deployment from Kustomize to Helm! #299

Closed

23 tasks

kumare3 reviewed Apr 9, 2021

View reviewed changes

rstanevich and others added 17 commits April 12, 2021 13:09

Helm chart for Flyte - initial commit

bf60426

Signed-off-by: Sören Brunk <[email protected]>

remove new lines

2519e72

Signed-off-by: Sören Brunk <[email protected]>

Added autogenerated Helm docs

1a7a9b1

Signed-off-by: Sören Brunk <[email protected]>

improve templates

b8d9b0c

Signed-off-by: Sören Brunk <[email protected]>

Support gRPC loadbalncing for EKS with AWS ALB

a55c691

Signed-off-by: Sören Brunk <[email protected]>

Use external chart dependencies for contour and spark-operator

85fde71

Bump versions Signed-off-by: Sören Brunk <[email protected]>

Helm - Update task plugin config

9309778

Based on the following kustomize changes: - cd4a3d5 Trim sandbox (flyteorg#727) - 9b59ac6 Update propeller version and config (flyteorg#580) Signed-off-by: Sören Brunk <[email protected]>

Helm - Updating Spark config to force default credentials chain for AWS

9701cf8

Based on the following kustomize change: - 0e2dd72 Updating Spark config to force default credentials chain for AWS (flyteorg#674) Signed-off-by: Sören Brunk <[email protected]>

Helm - Update contour GRPC annotation

26ac7ae

Based on the following kustomize change: - 46864a5 Access GRPC services using projectcontour (flyteorg#686) Signed-off-by: Sören Brunk <[email protected]>

Helm - Enabling Event version 1 by default

b540c38

Based on the following kustomize change: - 658aecd Enabling Event version 1 by default (flyteorg#689) Signed-off-by: Sören Brunk <[email protected]>

Helm - Improve getting started experience

3a68866

Based on the following kustomize change: - fbe7e68 Improve getting started experience (flyteorg#694) Signed-off-by: Sören Brunk <[email protected]>

Helm - Exponential error back-off in case of system errors

9f3eee4

Based on the following kustomize change: - 0844a44 Exponential error back-off in case of system errors (flyteorg#693) Signed-off-by: Sören Brunk <[email protected]>

Helm - Trim sandbox

fb35119

Based on the following kustomize change: - cd4a3d5 Trim sandbox (flyteorg#727) Signed-off-by: Sören Brunk <[email protected]>

Helm - Update default RAM Request for tasks in sandbox

c5f44be

Based on the following kustomize change: - 72c5705 Update default RAM Request for tasks in sandbox (flyteorg#750) Signed-off-by: Sören Brunk <[email protected]>

Helm - Update Admin task resources

1c03a3b

Based on the following kustomize change: - b13de21 Update Admin task resources (flyteorg#753) Signed-off-by: Sören Brunk <[email protected]>

Helm - Update EKS Ingress

e3ff3a8

Use default Docker images in EKS Helm values. Based on the following kustomize changes: - 4e0eed6 Update EKS Ingress and Instructions (flyteorg#825) Signed-off-by: Sören Brunk <[email protected]>

sbrunk added 3 commits April 12, 2021 13:09

Move GRPC annotations from ingress to services where possible

6ba497d

Signed-off-by: Sören Brunk <[email protected]>

Improve installation docs

064636c

Signed-off-by: Sören Brunk <[email protected]>

Downgrade Ingress API version for K8S 1.18 compatibility

f35a374

Signed-off-by: Sören Brunk <[email protected]>

kumare3 reviewed Apr 13, 2021

View reviewed changes

Add tls option for ingress

ff67bdb

Signed-off-by: Sören Brunk <[email protected]>

sbrunk force-pushed the helm-chart-with-dependencies branch from 125710b to ff67bdb Compare April 13, 2021 10:30

sbrunk closed this Apr 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm chart with dependencies #784

Helm chart with dependencies #784

sbrunk commented Mar 1, 2021

kumare3 commented Mar 3, 2021

sbrunk commented Mar 10, 2021

kumare3 Apr 9, 2021

sbrunk Apr 9, 2021

rstanevich Apr 12, 2021

kumare3 commented Apr 9, 2021

kumare3 Apr 9, 2021

sbrunk Apr 9, 2021

kumare3 Apr 12, 2021

kumare3 Apr 9, 2021

sbrunk Apr 9, 2021

kumare3 Apr 12, 2021

kumare3 Apr 13, 2021

sbrunk Apr 14, 2021

kumare3 Apr 13, 2021

kumare3 Apr 13, 2021

sbrunk commented Apr 22, 2021

Helm chart with dependencies #784

Helm chart with dependencies #784

Conversation

sbrunk commented Mar 1, 2021

kumare3 commented Mar 3, 2021

sbrunk commented Mar 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumare3 commented Apr 9, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbrunk commented Apr 22, 2021