Update getting starting page with a minimal example & link to flytesnacks #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yee Hing Tong <[email protected]>
kumare3
reviewed
Jan 29, 2021
kumare3
reviewed
Jan 29, 2021
|
|
||
| parsed_image.set(output_file) | ||
| @task | ||
| def edge_detection_canny(image_location:str) -> FlyteFile: |
There was a problem hiding this comment.
I would like the image_location to be a Flytefile ?
There was a problem hiding this comment.
i guess we can do that as a follow up
There was a problem hiding this comment.
are we keeping this opencv example?
kumare3
reviewed
Jan 29, 2021
kumare3
reviewed
Jan 29, 2021
kumare3
reviewed
Jan 29, 2021
kumare3
reviewed
Jan 29, 2021
kumare3
reviewed
Jan 29, 2021
kumare3
reviewed
Jan 29, 2021
|
PTAL @kumare3 |
kumare3
reviewed
Jan 30, 2021
| create_first | ||
| examples |
There was a problem hiding this comment.
you asked to change the order?
20 tasks
kumare3
reviewed
Feb 8, 2021
kumare3
reviewed
Feb 8, 2021
|
|
||
| git clone [email protected]:lyft/flytesnacks.git myflyteproject | ||
| git clone [email protected]:lyft/flytekit-python-template.git myflyteproject | ||
| cd myflyteproject | ||
| rm -rf .git | ||
| git init | ||
| cd python |
There was a problem hiding this comment.
Suggested change
| cd python | |
| cd myflyteproject |
There was a problem hiding this comment.
i'll just remove. we should already be in myflyteproject
kumare3
reviewed
Feb 8, 2021
| * A :py:class:`flytekit.types.file.FlyteFile` is a Flytekit type that represents binary data. It is used to offload data to a storage location like S3. Here we use it to store an image. | ||
|
|
||
|
|
||
| You can call this task ``edge_detection_canny(image_location="https://images.unsplash.com/photo-1512289984044-071903207f5e?ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&ixlib=rb-1.2.1&auto=format&fit=crop&w=2250&q=80")`` and iterate locally before adding it to part of a larger overall workflow. |
There was a problem hiding this comment.
better to make this a
.. code-block::
kumare3
reviewed
Feb 8, 2021
|
|
||
| If you have the flyte sandbox installed on your local machine, the image will be accessible to your Flyte system. If you're running a remote Flyte instance, you'll need to upload this image to a remote registry such as Dockerhub, Amazon ECR, or Google Container Registry, so that it can be used by the Flyte system. | ||
| You can call this workflow ``EdgeDetectorWf(image_input=...)`` and iterate locally before moving on to register it with Flyte. |
There was a problem hiding this comment.
same here, reason this is easy copy-pastable
Co-authored-by: Ketan Umare <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#677