Enabling RTD supported format for docs #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsts/make.bat
Outdated
| @@ -0,0 +1,36 @@ | |||
| @ECHO OFF | |||
There was a problem hiding this comment.
can we just delete this file?
There was a problem hiding this comment.
I guess we can, it is auto-generated
rsts/requirements.txt
Outdated
| @@ -0,0 +1,105 @@ | |||
| # | |||
There was a problem hiding this comment.
can you add a make target to generate this file?
There was a problem hiding this comment.
I did add it, what happened, - oops overrode it
rsts/conf.py
Outdated
| html_logo = "flyte_lockup_on_dark.png" | ||
| html_static_path = ['_static'] |
There was a problem hiding this comment.
Suggested change
| html_static_path = ['_static'] | |
| html_static_path = [] |
There was a problem hiding this comment.
if you don't do this you just get a warning every time you build.
| @@ -14,4 +14,4 @@ Getting Started | |||
|
|
|||
| examples | |||
| create_first | |||
| more_examples | |||
| Learn Flytekit by example <https://flytecookbook.readthedocs.io/en/latest/> | |||
There was a problem hiding this comment.
does this link work?
katrogan
previously approved these changes
Jan 28, 2021
wild-endeavor
previously approved these changes
Jan 28, 2021
wild-endeavor
approved these changes
Jan 28, 2021
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
* Update pod example for local run Signed-off-by: Alekhya Sai Punnamaraju <[email protected]> * Grammar changes Signed-off-by: Alekhya Sai Punnamaraju <[email protected]> * Apply suggestions from code review Co-authored-by: Samhita Alla <[email protected]> Co-authored-by: Samhita Alla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.