Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_eager bit to indicate eager tasks in flyte system (#6041) #6066

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

wild-endeavor
Copy link
Contributor

cherry-pick 25c89ee

* Add is_eager bit to indicate eager tasks in flyte system

Signed-off-by: pmahindrakar-oss <[email protected]>

* nit

Signed-off-by: pmahindrakar-oss <[email protected]>

---------

Signed-off-by: pmahindrakar-oss <[email protected]>
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 36.79%. Comparing base (730c502) to head (c86487e).
Report is 1 commits behind head on release-v1.13.

Files with missing lines Patch % Lines
...eidl/gen/pb-go/flyteidl/admin/node_execution.pb.go 0.00% 5 Missing ⚠️
flyteidl/gen/pb-go/flyteidl/core/tasks.pb.go 0.00% 5 Missing ⚠️
flyteidl/gen/pb-go/flyteidl/event/event.pb.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-v1.13    #6066      +/-   ##
=================================================
- Coverage          36.80%   36.79%   -0.01%     
=================================================
  Files               1309     1309              
  Lines             131026   131041      +15     
=================================================
+ Hits               48221    48222       +1     
- Misses             78612    78626      +14     
  Partials            4193     4193              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.03% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.90% <0.00%> (-0.01%) ⬇️
unittests-flyteplugins 53.67% <ø> (ø)
unittests-flytepropeller 42.88% <ø> (ø)
unittests-flytestdlib 55.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor merged commit 88d6e6a into release-v1.13 Dec 2, 2024
46 of 49 checks passed
@wild-endeavor wild-endeavor deleted the rel-v1.13-bp-6041-iseager branch December 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants