Inject offloading literal env vars #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6027 +/- ##
==========================================
+ Coverage 33.09% 37.06% +3.97%
==========================================
Files 1013 1316 +303
Lines 107489 132115 +24626
==========================================
+ Hits 35570 48967 +13397
- Misses 68767 78895 +10128
- Partials 3152 4253 +1101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pmahindrakar-oss
previously approved these changes
Nov 18, 2024
| envVars = append(envVars, | ||
| v1.EnvVar{ | ||
| Name: "_F_L_MIN_SIZE_MB", | ||
| Value: strconv.FormatInt(propellerConfig.LiteralOffloadingConfig.MinSizeInMBForOffloading, 10), |
There was a problem hiding this comment.
nit: we could directly use strconv.Itoa() which defaults to base 10
There was a problem hiding this comment.
https://pkg.go.dev/strconv#FormatInt handles int64 directly (which those two values are, instead of int).
Comment on lines
385
to
391
| assert.NoError(t, propellerCfg.SetConfig(&propellerCfg.Config{ | ||
| LiteralOffloadingConfig: propellerCfg.LiteralOffloadingConfig{ | ||
| Enabled: tt.offloadingEnabled, | ||
| MinSizeInMBForOffloading: 1, | ||
| MaxSizeInMBForOffloading: 42, | ||
| }, | ||
| })) |
There was a problem hiding this comment.
nit : I think instead of introducing SetConfig, you could do this
cfg := propellerCfg.GetConfig()
cfg.LiteralOffloadingConfig = propellerCfg.LiteralOffloadingConfig{
Enabled: tt.offloadingEnabled,
MinSizeInMBForOffloading: 1,
MaxSizeInMBForOffloading: 42,
}
As GetConfig returns a pointer.
Signed-off-by: Eduardo Apolinario <[email protected]>
pmahindrakar-oss
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #5103
Why are the changes needed?
Flytekit uses the environment variables _F_L_MIN_SIZE_MB and _F_L_MAX_SIZE_MB to define the minimum and maximum sizes (in MB) for offloading literals. This PR injects those variables in case offloading is enabled.
What changes were proposed in this pull request?
Inject 2 new variables to task pods in case offloading of literals is enabled.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link