Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused environment variable #5987

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

bgedik
Copy link
Contributor

@bgedik bgedik commented Nov 11, 2024

Tracking issue

Part of RFC https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend

Why are the changes needed?

With the PR #5795 there is not a need for a generic POD name environment variable. Instead the worker name environment variable is now used.

What changes were proposed in this pull request?

Remove an internal environment variable that was introduced via #5616

How was this patch tested?

Unit tests

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.94%. Comparing base (fa01e76) to head (994f513).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5987      +/-   ##
==========================================
- Coverage   36.94%   36.94%   -0.01%     
==========================================
  Files        1310     1310              
  Lines      131382   131373       -9     
==========================================
- Hits        48540    48531       -9     
  Misses      78629    78629              
  Partials     4213     4213              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.07% <ø> (ø)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.39% <ø> (ø)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.82% <ø> (-0.03%) ⬇️
unittests-flytepropeller 43.08% <ø> (ø)
unittests-flytestdlib 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fg91 fg91 merged commit 93f00a1 into flyteorg:master Nov 14, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants