Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix doc links to blob literal and type #5952

Conversation

JiangJiaWei1103
Copy link
Contributor

@JiangJiaWei1103 JiangJiaWei1103 commented Nov 3, 2024

Why are the changes needed?

The doc links to blob literal and type are outdated, so an update is needed for correct references.

What changes were proposed in this pull request?

Fix the doc links based on the new flyte project structure, instead of pointing to the old one.

  • Fixed link to blob literal
    Screenshot 2024-11-03 at 11 38 32 AM

  • Fixed link to blob type
    Screenshot 2024-11-03 at 11 40 26 AM

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All commits are signed-off.

Docs link

https://flyte--5952.org.readthedocs.build/en/5952/user_guide/data_types_and_io/flytefile.html

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.81%. Comparing base (704f8eb) to head (7f316b1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5952      +/-   ##
==========================================
+ Coverage   34.97%   36.81%   +1.83%     
==========================================
  Files        1144     1310     +166     
  Lines      122240   131032    +8792     
==========================================
+ Hits        42750    48235    +5485     
- Misses      75797    78611    +2814     
- Partials     3693     4186     +493     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.04% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.38% <ø> (?)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 42.90% <ø> (ø)
unittests-flytestdlib 55.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier enabled auto-merge (squash) November 3, 2024 07:24
@Future-Outlier Future-Outlier merged commit f745030 into flyteorg:master Nov 3, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants