Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]add cache information in raw containers doc #5876

Conversation

popojk
Copy link
Contributor

@popojk popojk commented Oct 21, 2024

Tracking issue

Closes #4461

Why are the changes needed?

In document user_guide/customizing_dependencies/raw_containers.html lacks information about cache configuration in Flyte's ContainerTask.

What changes were proposed in this pull request?

  1. Add information about cache configuration in Flyte's doc user_guide/customizing_dependencies/raw_containers.html.
  2. Add example code in flytesnacks, please refer to this PR.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All commits are signed-off.

Related PRs

flytesnacks PR

Docs link

Raw containers

Copy link

welcome bot commented Oct 21, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.71%. Comparing base (bdaf79f) to head (452f84e).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5876   +/-   ##
=======================================
  Coverage   36.71%   36.71%           
=======================================
  Files        1304     1304           
  Lines      130081   130081           
=======================================
  Hits        47764    47764           
  Misses      78147    78147           
  Partials     4170     4170           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.41% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.89% <ø> (ø)
unittests-flyteplugins 53.62% <ø> (ø)
unittests-flytepropeller 42.84% <ø> (ø)
unittests-flytestdlib 54.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier
Copy link
Member

docs link should be this:
https://flyte--5876.org.readthedocs.build/en/5876/user_guide/customizing_dependencies/raw_containers.html

@Future-Outlier Future-Outlier enabled auto-merge (squash) October 23, 2024 03:33
@Future-Outlier Future-Outlier merged commit 1652d4c into flyteorg:master Oct 23, 2024
50 checks passed
Copy link

welcome bot commented Oct 23, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] document how to set the cache for container tasks
3 participants