-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CONTRIBUTING.md and update #5873
Conversation
Signed-off-by: taieeuu <[email protected]>
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
For information related to contributing to Flyte, please check out the [Contributing to Flyte](https://docs.flyte.org/en/latest/community/contribute.html) section of the documentation. | ||
For information related to contributing to Flyte, please check out the [Contributing to Flyte](https://docs.flyte.org/en/latest/community/contribute/index.html) section of the documentation. | ||
|
||
## Recommendation Order (For Beginners) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for taking the initiative!
CONTRIBUTING.md
Outdated
|
||
## Recommendation Order (For Beginners) | ||
* Setup dev environment | ||
* Read the following and try to run 10 examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could lower the barrier here? Any number is arbitrary at this point so maybe something like "Run at least one example and pay close attention to effects: generated outputs, the Graph view, tasks logs, etc. Repeat with as many examples as you need to have an initial understanding of what an execution looks like" wdyt?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5873 +/- ##
==========================================
- Coverage 36.81% 36.81% -0.01%
==========================================
Files 1309 1309
Lines 130893 130895 +2
==========================================
Hits 48185 48185
- Misses 78526 78528 +2
Partials 4182 4182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CONTRIBUTING.md
Outdated
* Finish reading the [Control Plane](https://docs.flyte.org/en/latest/user_guide/concepts/control_plane/index.html) | ||
* Finish reading the [Component Architecture](https://docs.flyte.org/en/latest/user_guide/concepts/component_architecture/index.html) | ||
* Choose 2 good first issues from the following and start solving them with the knowledge you have read. | ||
* Familiar with using DOCKERFILE to push images to localhost for development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not the examples follow it today, we try to make ImageSpec first, and trying to avoid Dockerfiles
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Congrats on merging your first pull request! 🎉 |
Tracking issue
Reference #5868
Why are the changes needed?
Fix error link.And add the Recommendation Order for begineers
What changes were proposed in this pull request?
Check all the applicable boxes
Related PRs