Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to make scheduler under flyteadmin #5866

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

lowc1012
Copy link
Contributor

Tracking issue

None

Why are the changes needed?

Fails to execute "make scheduler" under flyteadmin

What changes were proposed in this pull request?

Fix Makefile

How was this patch tested?

Test locally

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.85%. Comparing base (bdaf79f) to head (2236dd6).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5866      +/-   ##
==========================================
- Coverage   36.71%   34.85%   -1.87%     
==========================================
  Files        1304     1138     -166     
  Lines      130081   121284    -8797     
==========================================
- Hits        47764    42274    -5490     
+ Misses      78147    75333    -2814     
+ Partials     4170     3677     -493     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.41% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl ?
unittests-flyteidl 6.89% <ø> (ø)
unittests-flyteplugins 53.62% <ø> (ø)
unittests-flytepropeller 42.84% <ø> (ø)
unittests-flytestdlib 54.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor enabled auto-merge (squash) October 23, 2024 00:19
@wild-endeavor wild-endeavor merged commit 595c552 into flyteorg:master Oct 23, 2024
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants