Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perian dependency for PERIAN plugin #5848

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Oct 15, 2024

Why are the changes needed?

The perian plugin depends on the perian package; in order to build flytekit docs about the perian plugin, we need to include that package in the docs requirements.

What changes were proposed in this pull request?

Adds perian package to monodocs-requirements.yaml and updates monodocs-requirements.lock.yaml with new dependency.

How was this patch tested?

Tested building docs locally with updated monodocs environment and FLYTEKIT_LOCAL_PATH set to @otarabai fork of flytekit that includes perian plugin docs updates.

Screenshots

Local docs build:

Screenshot 2024-10-15 at 11 54 01 AM

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytekit#2816

Docs link

https://flyte--5848.org.readthedocs.build/en/5848/ (Note: this is just to demonstrate that the docs build with the new dependency -- the perian flytekit docs won't be in this build because they're currently in a fork.)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.34%. Comparing base (f2a0619) to head (5fccc67).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5848   +/-   ##
=======================================
  Coverage   36.33%   36.34%           
=======================================
  Files        1304     1304           
  Lines      110137   110137           
=======================================
+ Hits        40023    40029    +6     
+ Misses      65946    65940    -6     
  Partials     4168     4168           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (+0.03%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.14% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (ø)
unittests-flytestdlib 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett neverett requested a review from ppiegaze October 15, 2024 21:14
@neverett neverett merged commit a2957cf into master Oct 15, 2024
50 checks passed
@neverett neverett deleted the nikki/docs/add-perian-dep branch October 15, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants